[libcxx] NFC: suppress warning on systems where sizeof(int) == sizeof(long)

[bcraig]

Summary

The old code produced a couple of these warnings...

src/string.cpp:95:11: warning: comparison of constant -2147483648 with expression of type 'long' (range [-2147483648, 2147483647]) is always false [-Wtautological-constant-out-of-range-compare]
  if (r < numeric_limits<int>::min() || numeric_limits<int>::max() < r)
      ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
src/string.cpp:95:11: note: place two sets of parentheses around the constant to silence this warning
  if (r < numeric_limits<int>::min() || numeric_limits<int>::max() < r)

This patch follows the advice of the note, as the comparison is reasonable on many 64-bit systems.

[EricWF]

How are you getting this warning? I can't generate it with Clang 3.8 on 64bit linux with -m32. In that configuration int and long have the same size.

[bcraig]

Looks like I found an out-of-tree warning in our compiler. Sorry about the noise. Abandoning.

src/string.cpp

 {
     // Use long as no Standard string to integer exists.
     long r = as_integer_helper<long>( func, s, idx, base, strtol );
-    if (r < numeric_limits<int>::min() || numeric_limits<int>::max() < r)
+    if (r < ((numeric_limits<int>::min())) || ((numeric_limits<int>::max())) < r)
         throw_from_string_out_of_range(func);
     return static_cast<int>(r);
 }

 {
     // Use long as no Stantard string to integer exists.
     long r = as_integer_helper<long>( func, s, idx, base, wcstol );
-    if (r < numeric_limits<int>::min() || numeric_limits<int>::max() < r)
+    if (r < ((numeric_limits<int>::min())) || ((numeric_limits<int>::max())) < r)
         throw_from_string_out_of_range(func);
     return static_cast<int>(r);
 }