Page MenuHomePhabricator

[OMPT]: Fix the order of implicit_task_end_events
ClosedPublic

Authored by tcramer on Jan 20 2016, 1:12 AM.

Details

Summary

For implcit barriers in simple parallel for loops the order of the OMPT events was wrong. The barrier_{begin,end} events came after the implcit_task_end event for the implcit barrier at the end of the parallel region. This wrong, because the implicit task executes the barrier before ending. This patch fixes the order of the event: It will be triggerd now just before __kmp_pop_current_task_from_thread() is called.

Diff Detail

Repository
rL LLVM

Event Timeline

tcramer updated this revision to Diff 45362.Jan 20 2016, 1:12 AM
tcramer retitled this revision from to [OMPT]: Fix the order of implicit_task_end_events.
tcramer updated this object.
tcramer added reviewers: jmellorcrummey, Hahnfeld.
tcramer set the repository for this revision to rL LLVM.
tcramer added a subscriber: tcramer.
tcramer edited subscribers, added: openmp-commits; removed: llvm-commits.
tcramer updated this object.Jan 20 2016, 1:39 AM
jlpeyton accepted this revision.Jan 26 2016, 1:48 PM
jlpeyton added a reviewer: jlpeyton.
jlpeyton added a subscriber: jlpeyton.

LGTM as well

This revision is now accepted and ready to land.Jan 26 2016, 1:49 PM
This revision was automatically updated to reflect the committed changes.