This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Fix for running tests after cmake transition
ClosedPublic

Authored by mcrosier on Jan 8 2016, 11:34 AM.

Details

Reviewers
MatzeB
Summary

This flag controls whether some tests are included when configuring.
It was missed when transitioning from configure to CMake, this adds it
back.

Affects archie-client and plot2fig in MultiSource/Benchmarks/Prolangs-C

Thanks.

Diff Detail

Event Timeline

mcrosier updated this revision to Diff 44349.Jan 8 2016, 11:34 AM
mcrosier retitled this revision from to [test-suite] Fix for running tests after cmake transition.
mcrosier updated this object.
mcrosier added a reviewer: MatzeB.
mcrosier added a subscriber: llvm-commits.
MatzeB accepted this revision.Jan 8 2016, 11:40 AM
MatzeB edited edge metadata.

LGTM. Though it might be a nice thing to move the check into MultiSource/Benchmarks/Prolangs-C/plot2fig/CMakeLists.txt and MultiSource/Benchmarks/Prolangs-C/archie-client/CMakeLists.txt if they are the only two affected, that way it becomes more obvious who/what needs that check. I think cmake also performs the check once and caches the result even if it appears in two different files.

This revision is now accepted and ready to land.Jan 8 2016, 11:40 AM
mcrosier updated this revision to Diff 44366.Jan 8 2016, 1:02 PM
mcrosier edited edge metadata.

Update per Matthias' comments.

mcrosier closed this revision.Jan 8 2016, 1:06 PM

Committed r257206.