This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Add CMake option to use host-timeit
ClosedPublic

Authored by mcrosier on Jan 4 2016, 1:51 PM.

Details

Reviewers
MatzeB
Summary

This change causes lit to use the host-compiled timeit when not remoting
into another host to run the test suite. timeit-target is intended to be
used on a host with the target architecture if cross-compiling, we
should always use timeit on the build host.

This is most important for cross-compiling and running under an
emulator, as timeit wraps around any run-under scripts given to lit.

Diff Detail

Event Timeline

mcrosier updated this revision to Diff 43921.Jan 4 2016, 1:51 PM
mcrosier retitled this revision from to [test-suite] Add CMake option to use host-timeit .
mcrosier updated this object.
mcrosier added a reviewer: MatzeB.
mcrosier set the repository for this revision to rL LLVM.
mcrosier added a subscriber: llvm-commits.
MatzeB edited edge metadata.Jan 5 2016, 12:01 PM

What about we avoid an extra configuration flag and just always use timeit except when remote_host is set? Something like this:

timeit = "%s/tools/timeit" % config.test_source_root # move upwards
# ...
if config.remote_host:
    timeit = "%s/tools/timeit-target" % config.test_source_root
mcrosier updated this revision to Diff 44060.Jan 5 2016, 2:16 PM
mcrosier updated this object.
mcrosier edited edge metadata.
mcrosier removed rL LLVM as the repository for this revision.

Use Matthis' suggestion.. Thanks!

MatzeB accepted this revision.Jan 5 2016, 2:56 PM
MatzeB edited edge metadata.

Nitpick: You could have moved the timeit assignment a bit upwards to reuse the existing "if config.remote_host:"

In any way LGTM.

This revision is now accepted and ready to land.Jan 5 2016, 2:56 PM
mcrosier updated this revision to Diff 44122.Jan 6 2016, 7:37 AM
mcrosier updated this object.
mcrosier edited edge metadata.

Address Matthias' nit.

mcrosier closed this revision.Jan 6 2016, 9:12 AM

Committed in r256944.