This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] On Darwin, link all frameworks with -fapplication-extension
ClosedPublic

Authored by zaks.anna on Dec 15 2015, 5:42 PM.

Details

Summary

The ASan dylib as well as other compiler-rt dylibs work with app extensions, so we should add -fapplication-extension to the link line when building them. This will avoid linker warnings when using the dylibs in app extensions.

(APIs unavailable to app extensions are listed here: https://developer.apple.com/library/ios/documentation/General/Conceptual/ExtensibilityPG/ExtensionOverview.html#//apple_ref/doc/uid/TP40014214-CH2-SW6)

Diff Detail

Repository
rL LLVM

Event Timeline

zaks.anna updated this revision to Diff 42948.Dec 15 2015, 5:42 PM
zaks.anna retitled this revision from to [compiler-rt] On Darwin, link all frameworks with -fapplication-extension.
zaks.anna updated this object.
zaks.anna added reviewers: llvm-commits, beanz.
beanz accepted this revision.Dec 17 2015, 3:30 PM
beanz edited edge metadata.

LGTM.

Thanks,
-Chris

This revision is now accepted and ready to land.Dec 17 2015, 3:30 PM
This revision was automatically updated to reflect the committed changes.