This is an archive of the discontinued LLVM Phabricator instance.

Differential D15487

[LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets
ClosedPublic

Authored by nitesh.jain on Dec 14 2015, 12:36 AM.

Details

Reviewers
clayborg
jaydeep
Summary

This Patch will allowed LLDB to debug respective instruction sets binaries.

Diff Detail

Repository
rL LLVM

Event Timeline

nitesh.jain updated this revision to Diff 42690.Dec 14 2015, 12:36 AM
nitesh.jain retitled this revision from to [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets.
nitesh.jain updated this object.
nitesh.jain added reviewers: jaydeep, clayborg.
nitesh.jain set the repository for this revision to rL LLVM.
nitesh.jain added subscribers: bhushan, slthakur, mohit.bhakkad, lldb-commits.
jaydeep accepted this revision.Dec 14 2015, 12:43 AM
jaydeep edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Dec 14 2015, 12:43 AM
clayborg accepted this revision.Dec 14 2015, 9:52 AM
clayborg edited edge metadata.
slthakur closed this revision.Dec 14 2015, 9:54 PM

Committed in revision 255619 on behalf of Nitesh Jain.

Revision Contents

PathSize
source/
Plugins/
ObjectFile/
ELF/
5 lines

Diff 42690

source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

Context not available.
switch (mips_arch) switch (mips_arch)
{ {
case llvm::ELF::EF_MIPS_ARCH_1:
case llvm::ELF::EF_MIPS_ARCH_2:
case llvm::ELF::EF_MIPS_ARCH_3:
case llvm::ELF::EF_MIPS_ARCH_4:
case llvm::ELF::EF_MIPS_ARCH_5:
case llvm::ELF::EF_MIPS_ARCH_32: case llvm::ELF::EF_MIPS_ARCH_32:
return (endian == ELFDATA2LSB) ? ArchSpec::eMIPSSubType_mips32el : ArchSpec::eMIPSSubType_mips32; return (endian == ELFDATA2LSB) ? ArchSpec::eMIPSSubType_mips32el : ArchSpec::eMIPSSubType_mips32;
case llvm::ELF::EF_MIPS_ARCH_32R2: case llvm::ELF::EF_MIPS_ARCH_32R2:
Context not available.