This is an archive of the discontinued LLVM Phabricator instance.

clang-format: Fix WebKit BeforeElse brace wrapping style
ClosedPublic

Authored by cjk on Dec 11 2015, 2:05 AM.

Details

Reviewers
djasper
Summary

Per https://webkit.org/code-style-guidelines/#linebreaking-else-braces,
WebKit style is for braces to be on the same line as the else.

Diff Detail

Event Timeline

cjk updated this revision to Diff 42512.Dec 11 2015, 2:05 AM
cjk retitled this revision from to clang-format: Fix WebKit BeforeElse brace wrapping style.
cjk updated this object.
cjk added a reviewer: djasper.
cjk added a comment.EditedDec 11 2015, 2:09 AM

@djasper: Tagged you because it seems like you've reviewed a bunch of recent clang-format patches. This is my first patch to any of the projects in the LLVM family, so please let me know if I've done something stupid, not added the proper reviewers/lists, etc.

Cheers!

djasper accepted this revision.Dec 11 2015, 2:40 AM
djasper edited edge metadata.

Looks good. Funny that we don't seem to have a test for this.

This revision is now accepted and ready to land.Dec 11 2015, 2:40 AM
cjk added a comment.Dec 11 2015, 12:36 PM

Excellent. Mind committing this on my behalf? I don't have commit access.

djasper closed this revision.Dec 14 2015, 12:33 AM

Submitted as r255484.