PassManager: remove unused parameters. NFC.

[thegameg]

Remove another one from PassManager.

[reames]

I think this patch - and the others of similar vein you've posted - are
flat out a bad idea. They diminish readability for no gain. Do you
have a good argument for why unnamed parameters are a good idea?

Philip

[thegameg]

The unused parameters cause warinings [-Wunused-parameter].

Would commenting the parameter names, or casting them to void in the
body of the function be a better idea?

[thegameg]

The 12/08/2015 10:48, Philip Reames wrote:

Depending on what we decide, this is possibly a warning which should be
fixed, or disabled. Which version of which compiler are you using?

I didn't know about the policy of the warnings for the headers used in
external projects. I'll just disable the warnings on LLVM for now, I guess.

Thank you for your time.

include/llvm/IR/PassManager.h

 /// analysis passes to be re-run to produce fresh results if any are needed.
 struct InvalidateAllAnalysesPass {
   /// \brief Run this pass over some unit of IR.
-  template <typename IRUnitT> PreservedAnalyses run(IRUnitT &Arg) {
+  template <typename IRUnitT> PreservedAnalyses run(IRUnitT &) {
     return PreservedAnalyses::none();
   }
 

include/llvm/IR/PassManagerInternal.h

     return *this;
   }
 
-  PreservedAnalysesT run(IRUnitT &IR, AnalysisManager<IRUnitT> *AM) override {
+  PreservedAnalysesT run(IRUnitT &IR, AnalysisManager<IRUnitT> *) override {
     return Pass.run(IR);
   }
   StringRef name() override { return PassT::name(); }