This is an archive of the discontinued LLVM Phabricator instance.

Differential D15184

[tsan] Enable building and testing TSan Go runtime on OS X
ClosedPublic

Authored by kubamracek on Dec 3 2015, 4:02 AM.

Details

Reviewers
kcc
glider
dvyukov
samsonov
Commits
rG87cd9c63df36: [tsan] Enable building and testing TSan Go runtime on OS X
rCRT254716: [tsan] Enable building and testing TSan Go runtime on OS X
rL254716: [tsan] Enable building and testing TSan Go runtime on OS X
Summary

The build and test actually work now, so let's just enable them.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 41737.Dec 3 2015, 4:02 AM
kubamracek retitled this revision from to [tsan] Enable building and testing TSan Go runtime on OS X.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, samsonov, glider, kcc.
kubamracek added subscribers: llvm-commits, zaks.anna.
dvyukov accepted this revision.Dec 3 2015, 4:45 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Dec 3 2015, 4:45 AM
Closed by commit rL254716: [tsan] Enable building and testing TSan Go runtime on OS X (authored by kuba.brecka). · Explain WhyDec 4 2015, 6:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
tsan/
10 lines
test/
tsan/
2 lines

Diff 41871

compiler-rt/trunk/lib/tsan/CMakeLists.txt

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Lines OBJECT_LIBS RTInterception
RTUbsan RTUbsan
CFLAGS ${TSAN_RTL_CFLAGS} CFLAGS ${TSAN_RTL_CFLAGS}
PARENT_TARGET tsan) PARENT_TARGET tsan)
add_compiler_rt_object_libraries(RTTsan_dynamic add_compiler_rt_object_libraries(RTTsan_dynamic
OS ${TSAN_SUPPORTED_OS} OS ${TSAN_SUPPORTED_OS}
ARCHS ${TSAN_SUPPORTED_ARCH} ARCHS ${TSAN_SUPPORTED_ARCH}
SOURCES ${TSAN_SOURCES} ${TSAN_CXX_SOURCES} ${TSAN_ASM_SOURCES} SOURCES ${TSAN_SOURCES} ${TSAN_CXX_SOURCES} ${TSAN_ASM_SOURCES}
CFLAGS ${TSAN_RTL_CFLAGS}) CFLAGS ${TSAN_RTL_CFLAGS})
# Build and check Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${OSX_SYSROOT_FLAG}"
IN_TMPDIR=1 SILENT=1 ${BUILDGO_SCRIPT}
DEPENDS tsan ${BUILDGO_SCRIPT}
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/go
COMMENT "Checking TSan Go runtime..."
VERBATIM)
else() else()
foreach(arch ${TSAN_SUPPORTED_ARCH}) foreach(arch ${TSAN_SUPPORTED_ARCH})
if(arch STREQUAL "x86_64") if(arch STREQUAL "x86_64")
set(TSAN_ASM_SOURCES rtl/tsan_rtl_amd64.S) set(TSAN_ASM_SOURCES rtl/tsan_rtl_amd64.S)
# Pass ASM file directly to the C++ compiler. # Pass ASM file directly to the C++ compiler.
set_source_files_properties(${TSAN_ASM_SOURCES} PROPERTIES set_source_files_properties(${TSAN_ASM_SOURCES} PROPERTIES
LANGUAGE C) LANGUAGE C)
# Sanity check for Go runtime. # Sanity check for Go runtime.
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines

compiler-rt/trunk/test/tsan/CMakeLists.txt

set(TSAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS}) set(TSAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
if(NOT ${COMPILER_RT_DEFAULT_TARGET_ARCH} MATCHES "mips" AND NOT APPLE) if(NOT ${COMPILER_RT_DEFAULT_TARGET_ARCH} MATCHES "mips")
list(APPEND TSAN_TEST_DEPS GotsanRuntimeCheck) list(APPEND TSAN_TEST_DEPS GotsanRuntimeCheck)
endif() endif()
if(NOT COMPILER_RT_STANDALONE_BUILD) if(NOT COMPILER_RT_STANDALONE_BUILD)
list(APPEND TSAN_TEST_DEPS tsan) list(APPEND TSAN_TEST_DEPS tsan)
endif() endif()
if(COMPILER_RT_HAS_LIBCXX_SOURCES AND if(COMPILER_RT_HAS_LIBCXX_SOURCES AND
COMPILER_RT_TEST_COMPILER_ID STREQUAL "Clang" COMPILER_RT_TEST_COMPILER_ID STREQUAL "Clang"
AND NOT APPLE) AND NOT APPLE)
Show All 21 Lines