This is an archive of the discontinued LLVM Phabricator instance.

Differential D15103

[LLDB][MIPS] Fix gdbremote_testcase.py
ClosedPublic

Authored by nitesh.jain on Nov 30 2015, 11:55 PM.

Details

Reviewers
ovyalov
clayborg
Commits
rG1e577e66e9b5: [LLDB][MIPS] Fix gdbremote_testcase.py Patch by Nitesh Jain
rLLDB254711: [LLDB][MIPS] Fix gdbremote_testcase.py
rL254711: [LLDB][MIPS] Fix gdbremote_testcase.py
Summary

To update the variable value like " g_c2" it required 3 machine instructions.

Diff Detail

Repository
rL LLVM

Event Timeline

nitesh.jain updated this revision to Diff 41465.Nov 30 2015, 11:55 PM
nitesh.jain retitled this revision from to [LLDB][MIPS] Fix gdbremote_testcase.py.
nitesh.jain updated this object.
nitesh.jain added reviewers: clayborg, ovyalov.
nitesh.jain set the repository for this revision to rL LLVM.
nitesh.jain added subscribers: jaydeep, bhushan, slthakur, mohit.bhakkad.
clayborg accepted this revision.Dec 1 2015, 9:48 AM
clayborg edited edge metadata.

This is fine. In the future we need to fix the test cases to not rely on exact instruction counts.

This revision is now accepted and ready to land.Dec 1 2015, 9:48 AM
ovyalov accepted this revision.Dec 2 2015, 10:40 AM
ovyalov edited edge metadata.
Closed by commit rL254711: [LLDB][MIPS] Fix gdbremote_testcase.py (authored by mohit.bhakkad). · Explain WhyDec 4 2015, 2:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
packages/
Python/
lldbsuite/
test/
tools/
lldb-server/
12 lines

Diff 41849

lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

Show First 20 Lines • Show All 1,267 Lines • ▼ Show 20 Lines def single_step_only_steps_one_instruction(self, use_Hc_packet=True, step_instruction="s"):
(state_reached, step_count) = self.count_single_steps_until_true(main_thread_id, self.g_c1_c2_contents_are, args, max_step_count=25, use_Hc_packet=use_Hc_packet, step_instruction=step_instruction) (state_reached, step_count) = self.count_single_steps_until_true(main_thread_id, self.g_c1_c2_contents_are, args, max_step_count=25, use_Hc_packet=use_Hc_packet, step_instruction=step_instruction)
self.assertTrue(state_reached) self.assertTrue(state_reached)
# Verify we hit the next state. # Verify we hit the next state.
args["expected_g_c1"] = "1" args["expected_g_c1"] = "1"
args["expected_g_c2"] = "0" args["expected_g_c2"] = "0"
(state_reached, step_count) = self.count_single_steps_until_true(main_thread_id, self.g_c1_c2_contents_are, args, max_step_count=5, use_Hc_packet=use_Hc_packet, step_instruction=step_instruction) (state_reached, step_count) = self.count_single_steps_until_true(main_thread_id, self.g_c1_c2_contents_are, args, max_step_count=5, use_Hc_packet=use_Hc_packet, step_instruction=step_instruction)
self.assertTrue(state_reached) self.assertTrue(state_reached)
self.assertEqual(step_count, 1) expected_step_count = 1
arch = self.getArchitecture()
#MIPS required "3" (ADDIU, SB, LD) machine instructions for updation of variable value
if re.match("mips",arch):
expected_step_count = 3
self.assertEqual(step_count, expected_step_count)
# Verify we hit the next state. # Verify we hit the next state.
args["expected_g_c1"] = "0" args["expected_g_c1"] = "0"
args["expected_g_c2"] = "0" args["expected_g_c2"] = "0"
(state_reached, step_count) = self.count_single_steps_until_true(main_thread_id, self.g_c1_c2_contents_are, args, max_step_count=5, use_Hc_packet=use_Hc_packet, step_instruction=step_instruction) (state_reached, step_count) = self.count_single_steps_until_true(main_thread_id, self.g_c1_c2_contents_are, args, max_step_count=5, use_Hc_packet=use_Hc_packet, step_instruction=step_instruction)
self.assertTrue(state_reached) self.assertTrue(state_reached)
self.assertEqual(step_count, 1) self.assertEqual(step_count, expected_step_count)
# Verify we hit the next state. # Verify we hit the next state.
args["expected_g_c1"] = "0" args["expected_g_c1"] = "0"
args["expected_g_c2"] = "1" args["expected_g_c2"] = "1"
(state_reached, step_count) = self.count_single_steps_until_true(main_thread_id, self.g_c1_c2_contents_are, args, max_step_count=5, use_Hc_packet=use_Hc_packet, step_instruction=step_instruction) (state_reached, step_count) = self.count_single_steps_until_true(main_thread_id, self.g_c1_c2_contents_are, args, max_step_count=5, use_Hc_packet=use_Hc_packet, step_instruction=step_instruction)
self.assertTrue(state_reached) self.assertTrue(state_reached)
self.assertEqual(step_count, 1) self.assertEqual(step_count, expected_step_count)