This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Detect an invalid answer in AtosSymbolizer
ClosedPublic

Authored by kubamracek on Nov 30 2015, 2:42 AM.

Details

Summary

On OS X, in AtosSymbolizer, if the answer from atos doesn't contain module name, let's bail and return false. There are some cases where this is beneficial, because we'll try DlAddrSymbolizer next (it's next in the symbolizer chain), which might be able to symbolize something that atos couldn't.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 41376.Nov 30 2015, 2:42 AM
kubamracek retitled this revision from to [sanitizer] Detect an invalid answer in AtosSymbolizer.
kubamracek updated this object.
kubamracek added reviewers: glider, kcc, samsonov, dvyukov.
kubamracek added subscribers: llvm-commits, zaks.anna.
dvyukov accepted this revision.Nov 30 2015, 3:21 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 3:21 AM
This revision was automatically updated to reflect the committed changes.