This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Fix signals and setjmp/longjmp on OS X
ClosedPublic

Authored by kubamracek on Nov 29 2015, 2:52 AM.

Details

Summary
  1. There's a few wrongly defined things in tsan_interceptors.cc,
  2. a typo in tsan_rtl_amd64.S which calls setjmp instead of sigsetjmp in the interceptor, and
  3. on OS X, accessing an mprotected page results in a SIGBUS (and not SIGSEGV).

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 41343.Nov 29 2015, 2:52 AM
kubamracek retitled this revision from to [tsan] Fix signals and setjmp/longjmp on OS X.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, samsonov, glider, kcc.
dvyukov accepted this revision.Nov 30 2015, 5:59 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 5:59 AM
This revision was automatically updated to reflect the committed changes.