This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Fix deadlock_detector_stress_test.cc testcase for OS X
ClosedPublic

Authored by kubamracek on Nov 20 2015, 1:38 AM.

Details

Summary

On OS X, we don't have pthread spinlocks, let's just use a regular mutex instead. Secondly, pthread_rwlock_t is much larger (200 bytes), so char padding_[64 - sizeof(pthread_rwlock_t)] actually underflows.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 40749.Nov 20 2015, 1:38 AM
kubamracek retitled this revision from to [tsan] Fix deadlock_detector_stress_test.cc testcase for OS X.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, kcc, glider, samsonov.
dvyukov accepted this revision.Nov 20 2015, 1:55 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Nov 20 2015, 1:55 AM
This revision was automatically updated to reflect the committed changes.