This is an archive of the discontinued LLVM Phabricator instance.

Add -disable-llvm-passes for frontend debug info tests.
ClosedPublic

Authored by danielcdh on Nov 19 2015, 4:11 PM.

Details

Summary

The frontend debuginfo tests should not invoke llvm passes which includes add-discriminators that will change the debug info generated by FE.

Diff Detail

Event Timeline

danielcdh updated this revision to Diff 40715.Nov 19 2015, 4:11 PM
danielcdh retitled this revision from to Add -disable-llvm-passes for frontend debug info tests..
danielcdh updated this object.
danielcdh added a reviewer: dblaikie.
danielcdh added a subscriber: llvm-commits.
dblaikie edited edge metadata.Nov 19 2015, 4:58 PM

Welcome to commit this sort of thing without pre-commit review (though if you want review it should go to cfe-commits rather than llvm-commits)

test/CodeGen/debug-info-scope.c
14

I imagine we want to preserve this comment - I guess that's what this test looked like before discriminators were added to it?

danielcdh updated this revision to Diff 40791.Nov 20 2015, 9:41 AM
danielcdh edited edge metadata.

Add comment back.

danielcdh marked an inline comment as done.Nov 20 2015, 9:42 AM
danielcdh edited subscribers, added: cfe-commits; removed: llvm-commits.
dblaikie accepted this revision.Nov 20 2015, 10:21 AM
dblaikie edited edge metadata.
This revision is now accepted and ready to land.Nov 20 2015, 10:21 AM
danielcdh closed this revision.Nov 20 2015, 10:31 AM