[tsan] Recognize frames coming from "libclang_rt.tsan_*" module as internal

[kubamracek]

Summary

On OS X, we build a dylib of the TSan runtime, which doesn't necessarily need to contain debugging symbols (and file and line information), so llvm-symbolizer might not be able to find file names for TSan internal frames. FrameIsInternal currently only considers filenames, but we should simply treat all frames within libclang_rt.tsan_osx_dynamic.dylib as internal. This patch treats all modules starting with libclang_rt.tsan_ as internal, because there may be more runtimes for other platforms in the future.

Also, this fixes one test failure on OS X.

[dvyukov]

Is there a test that fails today?

[dvyukov]

Also, this fixes one test failure on OS X.

OK

compiler-rt/trunk/lib/tsan/rtl/tsan_report.cc

if (rep->threads.Size())
     return rep->threads[0]->stack;
   return 0;
 }
 
 static bool FrameIsInternal(const SymbolizedStack *frame) {
   if (frame == 0)
     return false;
   const char *file = frame->info.file;
-  return file != 0 &&
-         (internal_strstr(file, "tsan_interceptors.cc") ||
-          internal_strstr(file, "sanitizer_common_interceptors.inc") ||
-          internal_strstr(file, "tsan_interface_"));
+  const char *module = frame->info.module;
+  if (file != 0 &&
+       internal_strstr(file, "tsan_interface_")))
+    return true;
+  if (module != 0 && (internal_strstr(module, "libclang_rt.tsan_")))
+    return true;
+  return false;
 }
 
 static SymbolizedStack *SkipTsanInternalFrames(SymbolizedStack *frames) {
   while (FrameIsInternal(frames) && frames->next)
     frames = frames->next;
   return frames;
 }