[asan] On OS X, write error reports into Crash Report.

[zaks.anna]

Summary

The Crash Report is going to add app specific info if it is stored in the magical buffer.

[glider]

lib/sanitizer_common/sanitizer_mac.h

45 ↗

(On Diff #40570)

According to http://lists.apple.com/archives/cocoa-dev/2013/Feb/msg00612.html and http://lists.apple.com/archives/cocoa-dev/2013/Feb/msg00613.html this isn't going to work on iOS, right?

[kubamracek]

lib/sanitizer_common/sanitizer_mac.h

45 ↗

(On Diff #40570)

That's correct, the iOS Crash Reporter intentionally doesn't include additional application-provided information in the crash logs.

[kubamracek]

LGTM.

[glider]

lib/sanitizer_common/sanitizer_mac.h

45 ↗

(On Diff #40570)

So don't we want to hide these bits behind "#if !SANITIZER_IOS" ?

[kubamracek]

lib/sanitizer_common/sanitizer_mac.h

45 ↗

(On Diff #40570)

The code still works for iOS simulator, and if we keep if unconditionally, then if a future iOS version starts including this in crash logs, we'd automatically benefit from that.

But I'm fine with #if !SANITIZER_IOS && !SANITIZER_IOSSIM, if you prefer that.

[glider]

lib/sanitizer_common/sanitizer_mac.h

45 ↗

(On Diff #40570)

No, I just was under the impression that we may get linker errors on iOS.
I'm fine with the current implementation.

compiler-rt/trunk/lib/sanitizer_common/sanitizer_mac.h

 //===-- sanitizer_mac.h -----------------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file is shared between various sanitizers' runtime libraries and
 // provides definitions for OSX-specific functions.
 //===----------------------------------------------------------------------===//
 #ifndef SANITIZER_MAC_H
 #define SANITIZER_MAC_H
 
+#include "sanitizer_common.h"
 #include "sanitizer_platform.h"
 #if SANITIZER_MAC
 #include "sanitizer_posix.h"
 
 namespace __sanitizer {
 
 enum MacosVersion {
   MACOS_VERSION_UNINITIALIZED = 0,
   MACOS_VERSION_UNKNOWN,
   MACOS_VERSION_LEOPARD,
   MACOS_VERSION_SNOW_LEOPARD,
   MACOS_VERSION_LION,
   MACOS_VERSION_MOUNTAIN_LION,
   MACOS_VERSION_MAVERICKS,
   MACOS_VERSION_YOSEMITE,
   MACOS_VERSION_UNKNOWN_NEWER
 };
 
 MacosVersion GetMacosVersion();
 
 char **GetEnviron();
 
 }  // namespace __sanitizer
 
+extern "C" {
+static char __crashreporter_info_buff__[kErrorMessageBufferSize] = {};
+static const char *__crashreporter_info__ __attribute__((__used__)) =
+  &__crashreporter_info_buff__[0];
+asm(".desc ___crashreporter_info__, 0x10");
+} // extern "C"
+
+INLINE void CRSetCrashLogMessage(const char *msg) {
+  internal_strlcpy(__crashreporter_info_buff__, msg,
+                   sizeof(__crashreporter_info_buff__)); }
+
 #endif  // SANITIZER_MAC
 #endif  // SANITIZER_MAC_H

compiler-rt/trunk/lib/sanitizer_common/sanitizer_mac.cc

#endif
   // environment to be fully initialized. Also, this should never be called when
   // holding the thread registry lock since that may result in a deadlock. If
   // the reporting thread holds the thread registry mutex, and asl_log waits
   // for GCD to dispatch a new thread, the process will deadlock, because the
   // pthread_create wrapper needs to acquire the lock as well.
   BlockingMutexLock l(&syslog_lock);
   if (common_flags()->log_to_syslog)
     WriteToSyslog(buffer);
+
+  // Log to CrashLog.
+  if (common_flags()->abort_on_error)
+    CRSetCrashLogMessage(buffer);
 }
 
 void GetPcSpBp(void *context, uptr *pc, uptr *sp, uptr *bp) {
   ucontext_t *ucontext = (ucontext_t*)context;
 # if defined(__aarch64__)
   *pc = ucontext->uc_mcontext->__ss.__pc;
 #   if defined(__IPHONE_8_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_8_0
   *bp = ucontext->uc_mcontext->__ss.__fp;