This is an archive of the discontinued LLVM Phabricator instance.

Differential D14764

Disable gvn non-local speculative loads under asan.
ClosedPublic

Authored by aizatsky on Nov 17 2015, 4:44 PM.

Details

Reviewers
kcc
Commits
rG52025af82098: Disable gvn non-local speculative loads under asan.
rCRT253499: Disable gvn non-local speculative loads under asan.
rL253499: Disable gvn non-local speculative loads under asan.
Summary

Fix for https://llvm.org/bugs/show_bug.cgi?id=25550

Diff Detail

Repository
rL LLVM

Event Timeline

aizatsky updated this revision to Diff 40455.Nov 17 2015, 4:44 PM
aizatsky retitled this revision from to Disable gvn non-local speculative loads under asan..
aizatsky updated this object.
aizatsky added a reviewer: kcc.Nov 17 2015, 4:46 PM
aizatsky added a subscriber: llvm-commits.
kcc accepted this revision.Nov 17 2015, 5:05 PM
kcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 17 2015, 5:05 PM
Closed by commit rL253499: Disable gvn non-local speculative loads under asan. (authored by aizatsky). · Explain WhyNov 18 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
asan/
TestCases/
21 lines

Diff 40542

compiler-rt/trunk/test/asan/TestCases/speculative_load2.cc

// Verifies that speculative loads from unions do not happen under asan.
// RUN: %clangxx_asan -O0 %s -o %t && ASAN_OPTIONS=detect_leaks=0 %run %t 2>&1
// RUN: %clangxx_asan -O1 %s -o %t && ASAN_OPTIONS=detect_leaks=0 %run %t 2>&1
// RUN: %clangxx_asan -O2 %s -o %t && ASAN_OPTIONS=detect_leaks=0 %run %t 2>&1
// RUN: %clangxx_asan -O3 %s -o %t && ASAN_OPTIONS=detect_leaks=0 %run %t 2>&1
typedef union {
short q;
struct {
short x;
short y;
int for_alignment;
} w;
} U;
int main() {
char *buf = new char[2];
buf[0] = buf[1] = 0x0;
U *u = (U *)buf;
return u->q == 0 ? 0 : u->w.y;
}