This is an archive of the discontinued LLVM Phabricator instance.

[mips][ias] Explicitly disable IAS on tests that depend on not assembling.
ClosedPublic

Authored by dsanders on Nov 16 2015, 7:31 AM.

Details

Summary

no-odd-spreg-msa.ll: This test deliberately uses an odd-numbered register
in inline assembly and expects the compiler to insert a move to an
even-numbered register.

inlineasm-operand-code.ll and inlineasm_constraint.ll:
Checks for IAS's output will be added once a matcher bug is resolved. This bug
causes the canonical output emitted by IAS to be incorrect for uimm16 constants
with the MSB set. We will still need the non-IAS checks at this point since
these tests primarily test formatting of operands.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 40287.Nov 16 2015, 7:31 AM
dsanders retitled this revision from to [mips][ias] Explicitly disable IAS on tests that depend on not assembling..
dsanders updated this object.
dsanders added a reviewer: vkalintiris.
dsanders added a subscriber: llvm-commits.
vkalintiris accepted this revision.Nov 18 2015, 3:44 AM
vkalintiris edited edge metadata.

LGTM.

test/CodeGen/Mips/inlineasm_constraint.ll
70

We don't define the IAS check prefix. Is this intentional to compare with GAS?

This revision is now accepted and ready to land.Nov 18 2015, 3:44 AM
dsanders added inline comments.Nov 26 2015, 3:21 AM
test/CodeGen/Mips/inlineasm_constraint.ll
70

It's because there's no way for force IAS enabled and I forgot to remove this line. I'll remove it and add it when I add the RUN line in the IAS-enable patch

dsanders closed this revision.Nov 26 2015, 3:25 AM