Page MenuHomePhabricator

Remove a broken hack from Scalar::ULongLong and fix a test
ClosedPublic

Authored by tberghammer on Nov 12 2015, 4:45 AM.

Details

Summary

Remove a broken hack from Scalar::ULongLong and fix a test

Change Test-rdar-12481949.py to expect GetValueAsUnsigned() to return
0xffffffff if the variable is an int32_t (signed, 4 byte integer) with
value of -1. The previous expectation where we expected the value to be
0xffffffffffffffff doesn't make sense as nothing explains why we would
treat it as an 8 byte value.

This CL also removes a hack from Scalar::ULongLong what was most likely
added to get this test passing as it only worked in case the value of
the variable is -1 and didn't make any sense even in that case.

Event Timeline

tberghammer retitled this revision from to Remove a broken hack from Scalar::ULongLong and fix a test.
tberghammer updated this object.
tberghammer added a subscriber: lldb-commits.
clayborg accepted this revision.Nov 12 2015, 9:46 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Nov 12 2015, 9:46 AM
This revision was automatically updated to reflect the committed changes.