This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Add a Darwin-specific lit test directory
ClosedPublic

Authored by kubamracek on Nov 12 2015, 4:36 AM.

Details

Summary

To test Darwin-specific changes and bugs, this patch creates a test/Darwin/ directory, allows '.mm' file extension for tests and adds a simple test that verifies that an Obj-C program can run and quit successfully.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 40030.Nov 12 2015, 4:36 AM
kubamracek retitled this revision from to [tsan] Add a Darwin-specific lit test directory.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, kcc, glider, samsonov.
glider accepted this revision.Nov 12 2015, 4:40 AM
glider edited edge metadata.

LGTM

test/tsan/Darwin/objc_bootstrap.mm
1 ↗(On Diff #40030)

Why is the file called "objc_bootstrap"? What are we bootstrapping here?

test/tsan/lit.cfg
67 ↗(On Diff #40030)

What about .m files?

This revision is now accepted and ready to land.Nov 12 2015, 4:40 AM
kubamracek updated this revision to Diff 40032.Nov 12 2015, 4:48 AM
kubamracek edited edge metadata.

Why is the file called "objc_bootstrap"? What are we bootstrapping here?

It was meant that TSan can actually bootstrap fine. Never mind, renamed to "objc-simple".

What about .m files?

Added.

This revision was automatically updated to reflect the committed changes.