This is an archive of the discontinued LLVM Phabricator instance.

tablegen: Simple heuristic for better pressure set names
ClosedPublic

Authored by MatzeB on Nov 11 2015, 4:27 PM.

Download Raw Diff

Details

Reviewers

Commits

rG167cbd216749: tablegen: Add a simple heuristic to get better names for pressure sets
rL253095: tablegen: Add a simple heuristic to get better names for pressure sets

Diff Detail

Repository: rL LLVM

Event Timeline

MatzeB updated this revision to Diff 39990.Nov 11 2015, 4:27 PM

MatzeB retitled this revision from to tablegen: Simple heuristic for better pressure set names.

MatzeB updated this object.

MatzeB added a reviewer: atrick.

MatzeB set the repository for this revision to rL LLVM.

MatzeB added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Nov 12 2015, 4:15 PM

Closed by commit rL253095: tablegen: Add a simple heuristic to get better names for pressure sets (authored by matze). · Explain WhyNov 13 2015, 2:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

utils/

TableGen/

CodeGenRegisters.cpp

6 lines

Diff 40180

llvm/trunk/utils/TableGen/CodeGenRegisters.cpp

Show First 20 Lines • Show All 1,568 Lines • ▼ Show 20 Lines	for (; SuperIdx != EndIdx; ++SuperIdx) {
unsigned UnitWeight = RegUnits[SubSet.Units[0]].Weight;		unsigned UnitWeight = RegUnits[SubSet.Units[0]].Weight;
const RegUnitSet &SuperSet = RegUnitSets[SuperIdx];		const RegUnitSet &SuperSet = RegUnitSets[SuperIdx];
if (isRegUnitSubSet(SubSet.Units, SuperSet.Units)		if (isRegUnitSubSet(SubSet.Units, SuperSet.Units)
&& (SubSet.Units.size() + 3 > SuperSet.Units.size())		&& (SubSet.Units.size() + 3 > SuperSet.Units.size())
&& UnitWeight == RegUnits[SuperSet.Units[0]].Weight		&& UnitWeight == RegUnits[SuperSet.Units[0]].Weight
&& UnitWeight == RegUnits[SuperSet.Units.back()].Weight) {		&& UnitWeight == RegUnits[SuperSet.Units.back()].Weight) {
DEBUG(dbgs() << "UnitSet " << SubIdx << " subsumed by " << SuperIdx		DEBUG(dbgs() << "UnitSet " << SubIdx << " subsumed by " << SuperIdx
<< "\n");		<< "\n");
		// We can pick any of the set names for the merged set. Go for the
		// shortest one to avoid picking the name of one of the classes that are
		// artificially created by tablegen. So "FPR128_lo" instead of
		// "QQQQ_with_qsub3_in_FPR128_lo".
		if (RegUnitSets[SubIdx].Name.size() < RegUnitSets[SuperIdx].Name.size())
		RegUnitSets[SuperIdx].Name = RegUnitSets[SubIdx].Name;
break;		break;
}		}
}		}
if (SuperIdx == EndIdx)		if (SuperIdx == EndIdx)
SuperSetIDs.push_back(SubIdx);		SuperSetIDs.push_back(SubIdx);
}		}
// Populate PrunedUnitSets with each equivalence class's superset.		// Populate PrunedUnitSets with each equivalence class's superset.
std::vector<RegUnitSet> PrunedUnitSets(SuperSetIDs.size());		std::vector<RegUnitSet> PrunedUnitSets(SuperSetIDs.size());
▲ Show 20 Lines • Show All 544 Lines • Show Last 20 Lines