This is an archive of the discontinued LLVM Phabricator instance.

Disabling sancov.cc on windows.
ClosedPublic

Authored by aizatsky on Nov 10 2015, 6:00 PM.

Download Raw Diff

Details

Reviewers

kcc
krasin

Commits

rGa543f77bdb6d: Disabling sancov.cc on windows.
rCRT252689: Disabling sancov.cc on windows.
rL252689: Disabling sancov.cc on windows.

Summary

It can't be built due to cxxabi missing. Will investigate later.

Diff Detail

Repository: rL LLVM

Event Timeline

aizatsky updated this revision to Diff 39877.Nov 10 2015, 6:00 PM

aizatsky retitled this revision from to Disabling sancov.cc on windows. It can't be built due to cxxabi missing. Will fix later..

aizatsky updated this object.

aizatsky retitled this revision from Disabling sancov.cc on windows. It can't be built due to cxxabi missing. Will fix later. to Disabling sancov.cc on windows. .Nov 10 2015, 6:01 PM

aizatsky updated this object.

aizatsky added reviewers: kcc, krasin.

aizatsky added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Nov 10 2015, 6:02 PM

Closed by commit rL252689: Disabling sancov.cc on windows. (authored by aizatsky). · Explain WhyNov 10 2015, 6:03 PM

This revision was automatically updated to reflect the committed changes.

krasin added inline comments.Nov 10 2015, 6:05 PM

lib/sanitizer_common/CMakeLists.txt
160 ↗	(On Diff #39877)	Will it work for MinGW or Cygwin?

Revision Contents

Path

Size

compiler-rt/

trunk/

lib/

sanitizer_common/

CMakeLists.txt

6 lines

Diff 39878

compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt

Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Lines	add_compiler_rt_object_libraries(RTSanitizerCommonLibc
CFLAGS ${SANITIZER_CFLAGS}		CFLAGS ${SANITIZER_CFLAGS}
DEFS ${SANITIZER_COMMON_DEFINITIONS})		DEFS ${SANITIZER_COMMON_DEFINITIONS})

# Unit tests for common sanitizer runtime.		# Unit tests for common sanitizer runtime.
if(COMPILER_RT_INCLUDE_TESTS)		if(COMPILER_RT_INCLUDE_TESTS)
add_subdirectory(tests)		add_subdirectory(tests)
endif()		endif()

		if (!MSVC)
add_llvm_tool(sancov sancov.cc)		add_llvm_tool(sancov sancov.cc)
target_link_libraries(sancov LLVMSupport LLVMSymbolize LLVMObject LLVMDebugInfoDWARF LLVMDebugInfoPDB)		target_link_libraries(sancov LLVMSupport LLVMSymbolize LLVMObject LLVMDebugInfoDWARF LLVMDebugInfoPDB)
		endif()