This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPS] Implement PREPEND, RADDU.W.QB, RDDSP, REPL.PH, REPL.QB, REPLV.PH, REPLV.QB and MTHLIP instructions
ClosedPublic

Authored by hvarga on Nov 9 2015, 10:56 PM.

Details

Summary

The patch implements microMIPSDSP instructions: PREPEND, RADDU.W.QB, RDDSP, REPL.PH, REPL.QB, REPLV.PH, REPLV.QB and MTHLIP.

Diff Detail

Repository
rL LLVM

Event Timeline

hvarga updated this revision to Diff 39784.Nov 9 2015, 10:56 PM
hvarga retitled this revision from to [mips][microMIPS] Implement PREPEND, RADDU.W.QB, RDDSP, REPL.PH, REPL.QB, REPLV.PH, REPLV.QB and MTHLIP instructions.
hvarga updated this object.
hvarga added subscribers: petarj, llvm-commits.
dsanders accepted this revision.Nov 27 2015, 1:47 AM
dsanders edited edge metadata.

LGTM with a possible nit depending on the answer to my question.

lib/Target/Mips/MicroMipsDSPInstrInfo.td
128–166 ↗(On Diff #39784)

Will each of these *_DESC_BASE's have more than one subclass? If not, you don't need a *_DESC_BASE and should just have a *_DESC

This revision is now accepted and ready to land.Nov 27 2015, 1:47 AM
This revision was automatically updated to reflect the committed changes.