This is an archive of the discontinued LLVM Phabricator instance.

AVX512 : VMOVHPS/PD and VMOVLPS/PD implementation.
ClosedPublic

Authored by igorb on Nov 9 2015, 1:13 AM.

Details

Summary

AVX512 : Implemented encoding and DAG lowering for VMOVHPS/PD and VMOVLPS/PD instructions.
Added tests for encoding.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb updated this revision to Diff 39670.Nov 9 2015, 1:13 AM
igorb retitled this revision from to AVX512 : VMOVHPS/PD and VMOVLPS/PD implementation..
igorb updated this object.
igorb added a reviewer: delena.
igorb set the repository for this revision to rL LLVM.
igorb added a subscriber: llvm-commits.
delena accepted this revision.Nov 9 2015, 11:57 AM
delena edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 9 2015, 11:57 AM
qcolombet added inline comments.
test/CodeGen/X86/avx-isa-check.ll
352 ↗(On Diff #39670)

Out of curiosity, what do these checks actually check?
I don’t see any CHECK lines.

delena added a subscriber: delena.Nov 9 2015, 12:10 PM

It is not a new test that should check DAG lowering. Igor added predicates to SSE/AVX patterns in order to use the same instruction from AVX512F set.
This test runs on all targets and just checks that nothing fails (checks target predicates).

  • Elena

I see, thanks for the information!

This revision was automatically updated to reflect the committed changes.