This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Skip building libcxx_tsan on OS X
ClosedPublic

Authored by kubamracek on Nov 8 2015, 9:15 AM.

Details

Summary

The TSan-instrumented version of libcxx doesn't even build on OS X at this point. Let's skip it from the OS X build for now, since most of TSan functionality doesn't depend on it. This will enable check-tsan to be run.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 39652.Nov 8 2015, 9:15 AM
kubamracek retitled this revision from to [tsan] Skip building libcxx_tsan on OS X.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, kcc, samsonov, glider.
dvyukov accepted this revision.Nov 8 2015, 9:34 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2015, 9:34 AM
This revision was automatically updated to reflect the committed changes.

Hi Kuba,

Did it fail to compile or link? I haven't tried it after rebasing my branch on top of your commits, but I believe it can build.