[tsan] Enable new/delete C++ interceptors for OS X

[kubamracek]

Summary

This patch adds tsan_new_delete.cc into the OS X build.

[glider]

compiler-rt/trunk/lib/tsan/rtl/tsan_new_delete.cc

15

Please keep the includes list sorted (clang-format might be your friend - don't remember if we use it in TSan)

27

I actually don't think it's a good idea to rename REAL(malloc) into __libc_malloc to match the Linux name.
I also vaguely remember that it might not be 100% correct to use the default libc allocator for TSan. Dima, didn't we want to change this?

[dvyukov]

compiler-rt/trunk/lib/tsan/rtl/tsan_new_delete.cc

27

It is OK to call into system malloc in tsan.
It would be great to get rid of system malloc calls in tsan, though. But that's definitely more work than these 2 defines.
Tsan uses system malloc for historical reasons. Initially we did not have internal allocator (nor sanitizer allocator at all), and using custom slab allocators proved to be too painful. Current internal allocator can eat huge amounts of memory, though.

[kubamracek]

compiler-rt/trunk/lib/tsan/rtl/tsan_new_delete.cc

15

Fixed in r252735.

compiler-rt/trunk/lib/tsan/CMakeLists.txt

 set(TSAN_RUNTIME_LIBRARIES)
 add_custom_target(tsan)
 
 if(APPLE)
   add_compiler_rt_runtime(clang_rt.tsan
     SHARED
     OS ${TSAN_SUPPORTED_OS}
     ARCHS ${TSAN_SUPPORTED_ARCH}
-    SOURCES ${TSAN_SOURCES}
+    SOURCES ${TSAN_SOURCES} ${TSAN_CXX_SOURCES}
     OBJECT_LIBS RTInterception
                 RTSanitizerCommon
                 RTSanitizerCommonLibc
                 RTUbsan
     CFLAGS ${TSAN_RTL_CFLAGS}
     PARENT_TARGET tsan)
 else()
   foreach(arch ${TSAN_SUPPORTED_ARCH})

compiler-rt/trunk/lib/tsan/rtl/tsan_new_delete.cc

 //===-- tsan_new_delete.cc ----------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file is a part of ThreadSanitizer (TSan), a race detector.
 //
 // Interceptors for operators new and delete.
 //===----------------------------------------------------------------------===//
 #include "sanitizer_common/sanitizer_internal_defs.h"
+#include "interception/interception.h"
 #include "tsan_interceptors.h"
 
 using namespace __tsan;  // NOLINT
 
 namespace std {
 struct nothrow_t {};
 }  // namespace std
 
+DECLARE_REAL(void *, malloc, uptr size)
+DECLARE_REAL(void, free, void *ptr)
+#if SANITIZER_MAC
+#define __libc_malloc REAL(malloc)
+#define __libc_free REAL(free)
+#endif
+
 #define OPERATOR_NEW_BODY(mangled_name) \
   if (cur_thread()->in_symbolizer) \
     return __libc_malloc(size); \
   void *p = 0; \
   {  \
     SCOPED_INTERCEPTOR_RAW(mangled_name, size); \
     p = user_alloc(thr, pc, size); \
   }  \