Page MenuHomePhabricator

Make lldb-gdbserver to take explicit socket scheme as command line argument
ClosedPublic

Authored by ovyalov on Oct 27 2015, 11:53 AM.

Details

Reviewers
clayborg
Summary

Make lldb-gdbserver to take explicit socket scheme as command line argument - so lldb gdb-server uses the same socket type as platform does.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 38579.Oct 27 2015, 11:53 AM
ovyalov retitled this revision from to Make lldb-gdbserver to take explicit socket scheme as command line argument.
ovyalov updated this object.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
clayborg requested changes to this revision.Oct 27 2015, 12:37 PM
clayborg edited edge metadata.

Need to make a copy of socket_scheme in GDBRemoteCommunicationServerPlatform (save it to a std::string).

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h
71

We should make a copy in a std::string here.

This revision now requires changes to proceed.Oct 27 2015, 12:37 PM
ovyalov updated this revision to Diff 38588.Oct 27 2015, 1:44 PM
ovyalov edited edge metadata.

Addressed review comments - please take another look.

Greg, is it ok to submit the CL?

clayborg accepted this revision.Oct 28 2015, 12:46 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Oct 28 2015, 12:46 PM
ovyalov closed this revision.Oct 28 2015, 12:52 PM

Files:

/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h
/lldb/trunk/tools/lldb-server/Acceptor.cpp
/lldb/trunk/tools/lldb-server/Acceptor.h
/lldb/trunk/tools/lldb-server/lldb-platform.cpp

Users:

ovyalov (Author)

http://reviews.llvm.org/rL251547