This is an archive of the discontinued LLVM Phabricator instance.

Differential D13975

Make string constants in the modernize module static.
ClosedPublic

Authored by angelgarcia on Oct 22 2015, 2:40 AM.

Details

Reviewers
klimek
Commits
rG146b96dfcb8b: Make string constants in the modernize module static.
rCTE251005: Make string constants in the modernize module static.
rL251005: Make string constants in the modernize module static.
Summary

Add static to global variables, if they are not in an anonymous namespace.

Diff Detail

Event Timeline

angelgarcia updated this revision to Diff 38104.Oct 22 2015, 2:40 AM
angelgarcia retitled this revision from to Make string constants in the modernize module static..
angelgarcia updated this object.
angelgarcia added a reviewer: klimek.
angelgarcia added a subscriber: cfe-commits.
klimek accepted this revision.Oct 22 2015, 2:47 AM
klimek edited edge metadata.

lg

This revision is now accepted and ready to land.Oct 22 2015, 2:47 AM
angelgarcia closed this revision.Oct 22 2015, 2:50 AM

Revision Contents

PathSize
clang-tidy/
modernize/
26 lines
6 lines
4 lines

Diff 38104

clang-tidy/modernize/LoopConvertCheck.cpp

Show All 13 Lines
using namespace clang; using namespace clang;
using namespace clang::ast_matchers; using namespace clang::ast_matchers;
using namespace llvm; using namespace llvm;
namespace clang { namespace clang {
namespace tidy { namespace tidy {
namespace modernize { namespace modernize {
const char LoopNameArray[] = "forLoopArray"; static const char LoopNameArray[] = "forLoopArray";
const char LoopNameIterator[] = "forLoopIterator"; static const char LoopNameIterator[] = "forLoopIterator";
const char LoopNamePseudoArray[] = "forLoopPseudoArray"; static const char LoopNamePseudoArray[] = "forLoopPseudoArray";
const char ConditionBoundName[] = "conditionBound"; static const char ConditionBoundName[] = "conditionBound";
const char ConditionVarName[] = "conditionVar"; static const char ConditionVarName[] = "conditionVar";
const char IncrementVarName[] = "incrementVar"; static const char IncrementVarName[] = "incrementVar";
const char InitVarName[] = "initVar"; static const char InitVarName[] = "initVar";
const char BeginCallName[] = "beginCall"; static const char BeginCallName[] = "beginCall";
const char EndCallName[] = "endCall"; static const char EndCallName[] = "endCall";
const char ConditionEndVarName[] = "conditionEndVar"; static const char ConditionEndVarName[] = "conditionEndVar";
const char EndVarName[] = "endVar"; static const char EndVarName[] = "endVar";
const char DerefByValueResultName[] = "derefByValueResult"; static const char DerefByValueResultName[] = "derefByValueResult";
const char DerefByRefResultName[] = "derefByRefResult"; static const char DerefByRefResultName[] = "derefByRefResult";
// shared matchers // shared matchers
static const TypeMatcher AnyType = anything(); static const TypeMatcher AnyType = anything();
static const StatementMatcher IntegerComparisonMatcher = static const StatementMatcher IntegerComparisonMatcher =
expr(ignoringParenImpCasts( expr(ignoringParenImpCasts(
declRefExpr(to(varDecl(hasType(isInteger())).bind(ConditionVarName))))); declRefExpr(to(varDecl(hasType(isInteger())).bind(ConditionVarName)))));
▲ Show 20 Lines • Show All 821 Lines • Show Last 20 Lines

clang-tidy/modernize/MakeUniqueCheck.cpp

Show All 12 Lines
#include "clang/Lex/Lexer.h" #include "clang/Lex/Lexer.h"
using namespace clang::ast_matchers; using namespace clang::ast_matchers;
namespace clang { namespace clang {
namespace tidy { namespace tidy {
namespace modernize { namespace modernize {
const char PointerType[] = "pointerType"; static const char PointerType[] = "pointerType";
const char ConstructorCall[] = "constructorCall"; static const char ConstructorCall[] = "constructorCall";
const char NewExpression[] = "newExpression"; static const char NewExpression[] = "newExpression";
void MakeUniqueCheck::registerMatchers(MatchFinder *Finder) { void MakeUniqueCheck::registerMatchers(MatchFinder *Finder) {
if (getLangOpts().CPlusPlus11) { if (getLangOpts().CPlusPlus11) {
Finder->addMatcher( Finder->addMatcher(
cxxBindTemporaryExpr(has( cxxBindTemporaryExpr(has(
cxxConstructExpr( cxxConstructExpr(
hasType(qualType(hasDeclaration(classTemplateSpecializationDecl( hasType(qualType(hasDeclaration(classTemplateSpecializationDecl(
matchesName("::std::unique_ptr"), matchesName("::std::unique_ptr"),
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines

clang-tidy/modernize/ReplaceAutoPtrCheck.cpp

Show All 15 Lines
using namespace clang; using namespace clang;
using namespace clang::ast_matchers; using namespace clang::ast_matchers;
namespace clang { namespace clang {
namespace tidy { namespace tidy {
namespace modernize { namespace modernize {
const char AutoPtrTokenId[] = "AutoPrTokenId"; static const char AutoPtrTokenId[] = "AutoPrTokenId";
const char AutoPtrOwnershipTransferId[] = "AutoPtrOwnershipTransferId"; static const char AutoPtrOwnershipTransferId[] = "AutoPtrOwnershipTransferId";
/// \brief Matches expressions that are lvalues. /// \brief Matches expressions that are lvalues.
/// ///
/// In the following example, a[0] matches expr(isLValue()): /// In the following example, a[0] matches expr(isLValue()):
/// \code /// \code
/// std::string a[2]; /// std::string a[2];
/// std::string b; /// std::string b;
/// b = a[0]; /// b = a[0];
▲ Show 20 Lines • Show All 237 Lines • Show Last 20 Lines