Page MenuHomePhabricator

Remove more gcc warnings.
AbandonedPublic

Authored by abidh on Oct 19 2015, 5:59 AM.

Details

Reviewers
clayborg
Summary

I saw following gcc warnings in 3 places and they seem to make sense.

"comparison of unsigned expression >= 0 is always true [-Wtype-limits]"

To fix the warnings, I have removed the offending checks. OK?

Diff Detail

Event Timeline

abidh updated this revision to Diff 37747.Oct 19 2015, 5:59 AM
abidh retitled this revision from to Remove more gcc warnings..
abidh updated this object.
abidh added a reviewer: clayborg.
abidh added a subscriber: lldb-commits.
clayborg requested changes to this revision.Oct 19 2015, 10:39 AM
clayborg edited edge metadata.

Please don't check this in. If dwarf_r0 changes from 0 to another value, then this code will fail. We will need to live with these warnings.

This revision now requires changes to proceed.Oct 19 2015, 10:39 AM
abidh abandoned this revision.Oct 20 2015, 1:18 AM