This is an archive of the discontinued LLVM Phabricator instance.

ccc-analyzer: Fix -isystem value passing
ClosedPublic

Authored by Lekensteyn on Oct 16 2015, 3:46 AM.

Details

Summary

The previous and current regex are broken.

-[D,I,Usystem] matches "-D", "-,", "-I", "-U", "-s" "-y", etc. Besides that, "-isystem /foo" gets interpreted as "-i" with a non-empty value "system" and thus the next "/foo" argument is not read. This patch corrects the regex.

Fixes https://llvm.org/bugs/show_bug.cgi?id=13237

Diff Detail

Repository
rL LLVM

Event Timeline

Lekensteyn updated this revision to Diff 37567.Oct 16 2015, 3:46 AM
Lekensteyn retitled this revision from to ccc-analyzer: Fix -isystem value passing.
Lekensteyn updated this object.
Lekensteyn added a reviewer: krememek.
Lekensteyn added a subscriber: cfe-commits.
dcoughlin accepted this revision.Oct 25 2015, 7:52 PM
dcoughlin edited edge metadata.

Looks good to me. I will commit.

This revision is now accepted and ready to land.Oct 25 2015, 7:52 PM
This revision was automatically updated to reflect the committed changes.