Initialize BasicAAWrapperPass in it's constructor

[loladiro]

Summary

This seems to be the idiom used elsewhere in LLVM. Is there some reason this shouldn't be there or is that just an oversight?

[loladiro]

bump

[chandlerc]

Probably just an oversight. Thanks for the fix, LGTM.

llvm/trunk/include/llvm/Analysis/BasicAliasAnalysis.h

 class BasicAAWrapperPass : public FunctionPass {
   std::unique_ptr<BasicAAResult> Result;
 
   virtual void anchor();
 
 public:
   static char ID;
 
-  BasicAAWrapperPass() : FunctionPass(ID) {}
+  BasicAAWrapperPass();
 
   BasicAAResult &getResult() { return *Result; }
   const BasicAAResult &getResult() const { return *Result; }
 
   bool runOnFunction(Function &F) override;
   void getAnalysisUsage(AnalysisUsage &AU) const override;
 };
 

llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp

 BasicAAResult BasicAA::run(Function &F, AnalysisManager<Function> *AM) {
   return BasicAAResult(F.getParent()->getDataLayout(),
                        AM->getResult<TargetLibraryAnalysis>(F),
                        AM->getResult<AssumptionAnalysis>(F),
                        AM->getCachedResult<DominatorTreeAnalysis>(F),
                        AM->getCachedResult<LoopAnalysis>(F));
 }
 
+BasicAAWrapperPass::BasicAAWrapperPass() : FunctionPass(ID) {
+    initializeBasicAAWrapperPassPass(*PassRegistry::getPassRegistry());
+}
+
 char BasicAAWrapperPass::ID = 0;
 void BasicAAWrapperPass::anchor() {}
 
 INITIALIZE_PASS_BEGIN(BasicAAWrapperPass, "basicaa",
                       "Basic Alias Analysis (stateless AA impl)", true, true)
 INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker)
 INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
 INITIALIZE_PASS_END(BasicAAWrapperPass, "basicaa",