This is an archive of the discontinued LLVM Phabricator instance.

Differential D13429

Provide missing Internal{Alloc, Free} declarations for libbacktrace symbolizer.
ClosedPublic

Authored by m.ostapenko on Oct 5 2015, 3:07 AM.

Details

Reviewers
kcc
samsonov
eugenis
Commits
rGd9cc7f884fd5: Provide missing Internal{Alloc, Free} declarations for libbacktrace symbolizer.
rCRT249633: Provide missing Internal{Alloc, Free} declarations for libbacktrace symbolizer.
rL249633: Provide missing Internal{Alloc, Free} declarations for libbacktrace symbolizer.
Summary

Since r223145 we don't include sanitizer_allocator_internal.h into sanitizer_symbolizer.h, so we can have undefined reference to Internal{Alloc, Free} stuff into sanitizer_symbolizer_libbacktrace.cc under SANITIZER_CP_DEMANGLE macro.

This patch simply includes appropriate header into sanitizer_symbolizer_libbacktrace.h to resolve the issue.

Diff Detail

Repository
rL LLVM

Event Timeline

m.ostapenko updated this revision to Diff 36489.Oct 5 2015, 3:07 AM
m.ostapenko retitled this revision from to Provide missing Internal{Alloc, Free} declarations for libbacktrace symbolizer..
m.ostapenko updated this object.
m.ostapenko added reviewers: kcc, eugenis, samsonov.
m.ostapenko set the repository for this revision to rL LLVM.
m.ostapenko added a subscriber: ygribov.
samsonov accepted this revision.Oct 5 2015, 10:13 AM
samsonov edited edge metadata.

LGTM

lib/sanitizer_common/sanitizer_symbolizer_libbacktrace.h
20 ↗(On Diff #36489)

Please put it between sanitizer_common.h and sanitizer_symbolizer_internal.h

This revision is now accepted and ready to land.Oct 5 2015, 10:13 AM
samsonov added a subscriber: llvm-commits.Oct 5 2015, 10:14 AM
m.ostapenko updated this revision to Diff 36527.Oct 5 2015, 10:24 AM
m.ostapenko edited edge metadata.
m.ostapenko removed rL LLVM as the repository for this revision.

Addressing Alexey's comment.

m.ostapenko added a comment.Oct 5 2015, 11:06 AM

Alexey, could you please apply this? Thanks!

m.ostapenko added a comment.Oct 7 2015, 7:14 AM

Ping. Could someone please commit this for me?

samsonov added a comment.Oct 7 2015, 4:09 PM

Sorry for delay. Submitting this now.

Closed by commit rL249633: Provide missing Internal{Alloc, Free} declarations for libbacktrace symbolizer. (authored by samsonov). · Explain WhyOct 7 2015, 4:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
sanitizer_common/
1 line

Diff 36808

compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_libbacktrace.h

Show All 10 Lines
// run-time libraries. // run-time libraries.
// Header for libbacktrace symbolizer. // Header for libbacktrace symbolizer.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef SANITIZER_SYMBOLIZER_LIBBACKTRACE_H #ifndef SANITIZER_SYMBOLIZER_LIBBACKTRACE_H
#define SANITIZER_SYMBOLIZER_LIBBACKTRACE_H #define SANITIZER_SYMBOLIZER_LIBBACKTRACE_H
#include "sanitizer_platform.h" #include "sanitizer_platform.h"
#include "sanitizer_common.h" #include "sanitizer_common.h"
#include "sanitizer_allocator_internal.h"
#include "sanitizer_symbolizer_internal.h" #include "sanitizer_symbolizer_internal.h"
#ifndef SANITIZER_LIBBACKTRACE #ifndef SANITIZER_LIBBACKTRACE
# define SANITIZER_LIBBACKTRACE 0 # define SANITIZER_LIBBACKTRACE 0
#endif #endif
#ifndef SANITIZER_CP_DEMANGLE #ifndef SANITIZER_CP_DEMANGLE
# define SANITIZER_CP_DEMANGLE 0 # define SANITIZER_CP_DEMANGLE 0
Show All 23 Lines