This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Remove uses of std::unique_ptr<T[N]> from test to prevent warning.
AbandonedPublic

Authored by EricWF on Oct 1 2015, 12:51 AM.

Details

Reviewers
mclow.lists
Summary

constructing a std::unique_ptr<T[N]> will always cause a warning because the deleter (std::default_delete<T[N]>) will call delete ptr instead of delete [] ptr. This is a bug in the standard, not libc++.

I don't see a reason why removing the test cases will decrease coverage because std::unique_ptr<T> and std::unique_ptr<T[N]> select the same primary template. However since @mclow.lists wrote this test I want him to approve this patch.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 36195.Oct 1 2015, 12:51 AM
EricWF retitled this revision from to [libcxx] Remove uses of std::unique_ptr<T[N]> from test to prevent warning..
EricWF updated this object.
EricWF added a reviewer: mclow.lists.
EricWF added subscribers: cfe-commits, mclow.lists.
EricWF abandoned this revision.Dec 27 2016, 10:45 PM

This was already committed.