Page MenuHomePhabricator

test events: announce worker count in new initialize event
ClosedPublic

Authored by tfiala on Sep 18 2015, 3:38 PM.

Details

Reviewers
clayborg
Summary

This change:

  • renames TestFormatter.process_event() to TestFormatter.handle_event()
  • does away with TestFormatter.begin_session()/end_session(), replacing them with new initialize and terminate events. Now everything goes through handle_event().
  • passes the worker count (thread/process count) in the initialize event.
  • really adds the inferior dotest.py pid to all test events. Looks like I lost that at some point as it was only coming in on the inferior process begin/end messages.
  • names the inferior process begin/end messages to job_begin and job_end.
  • fixes some ugly output and invalid handling when Ctrl-C happened with my previous change (grabbing the worker index would blow up when we were tearing down the multiprocessing.Manager when accessing its shared proxy dictionary.)

Diff Detail

Event Timeline

tfiala updated this revision to Diff 35145.Sep 18 2015, 3:38 PM
tfiala retitled this revision from to test events: announce worker count in new initialize event.
tfiala updated this object.
tfiala added a reviewer: clayborg.
tfiala added a subscriber: lldb-commits.
clayborg accepted this revision.Sep 18 2015, 3:42 PM
clayborg edited edge metadata.

Looks good

This revision is now accepted and ready to land.Sep 18 2015, 3:42 PM
tfiala closed this revision.Sep 18 2015, 3:47 PM

Sending test/dosep.py
Sending test/dotest.py
Sending test/dotest_args.py
Sending test/test_results.py
Transmitting file data ....
Committed revision 248059.