Page MenuHomePhabricator

Add support for the DWARFLocationList used by split-dwarf
ClosedPublic

Authored by tberghammer on Sep 15 2015, 7:41 AM.

Details

Summary

Add support for the DWARFLocationList used by split-dwarf

Split-dwarf uses a different header format to specify the address range for the elements of the location lists.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Add support for the DWARFLocationList used by split-dwarf.
tberghammer updated this object.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
clayborg requested changes to this revision.Sep 15 2015, 2:25 PM
clayborg edited edge metadata.

Looks good, we just need to relocate the DWARF expression printing stuff over into DWARFExpression as static functions.

source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
36–228 ↗(On Diff #34802)

print_dwarf_exp_op, print_dwarf_expression, and print_dwarf_location_list should probably go into DWARFExpression.cpp as static functions on the DWARFExpression class.

This revision now requires changes to proceed.Sep 15 2015, 2:25 PM
tberghammer marked an inline comment as done.Sep 16 2015, 5:37 AM
tberghammer added inline comments.
source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
36–228 ↗(On Diff #34802)

I moved them to DWARFExpression.cpp and also cleaned up them a little bit

This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.