[analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

[dcoughlin]

Summary

Update the static analyzer buildbot script to set -isysroot to the OS X SDK path when analyzing preprocessed files.

[xazax.hun]

utils/analyzer/SATestBuild.py

277 ↗

(On Diff #34466)

I think it might be better to check if the host os is OS X. This way one might be able to check preprocessed files on other linux.

[xazax.hun]

• on other OS-es like linux.

[dcoughlin]

utils/analyzer/SATestBuild.py

277 ↗

(On Diff #34466)

The patch checks for the existence of xcrun in the path and doesn't set -isysroot if that is not present, so this should continue to work on Linux and cygwin.

[xazax.hun]

utils/analyzer/SATestBuild.py

277 ↗

(On Diff #34466)

I see, however -cc1 option is only used when the SDKPath is not None. Is this intended?

[dcoughlin]

utils/analyzer/SATestBuild.py

277 ↗

(On Diff #34466)

No, you're right -- that is not intended.

[dcoughlin]

Pass -cc1 to clang even when SDK path is not found.

[xazax.hun]

It looks good to me.

cfe/trunk/utils/analyzer/SATestBuild.py

 import csv
 import sys
 import glob
 import math
 import shutil
 import time
 import plistlib
 import argparse
-from subprocess import check_call, CalledProcessError
+from subprocess import check_call, check_output, CalledProcessError
 
 #------------------------------------------------------------------------------
 # Helper functions.
 #------------------------------------------------------------------------------
 
 def detectCPUs():
     """
     Detects the number of CPUs on a system. Cribbed from pp.

 def isValidSingleInputFile(FileName):
     (Root, Ext) = os.path.splitext(FileName)
     if ((Ext == ".i") | (Ext == ".ii") |
         (Ext == ".c") | (Ext == ".cpp") |
         (Ext == ".m") | (Ext == "")) :
         return True
     return False
 
+# Get the path to the SDK for the given SDK name. Returns None if
+# the path cannot be determined.
+def getSDKPath(SDKName):
+    if which("xcrun") is None:
+        return None
+
+    Cmd = "xcrun --sdk " + SDKName + " --show-sdk-path"
+    return check_output(Cmd, shell=True).rstrip()
+
 # Run analysis on a set of preprocessed files.
 def runAnalyzePreprocessed(Dir, SBOutputDir, Mode):
     if os.path.exists(os.path.join(Dir, BuildScript)):
         print "Error: The preprocessed files project should not contain %s" % \
                BuildScript
         raise Exception()
 
-    CmdPrefix = Clang + " -cc1 -analyze -analyzer-output=plist -w "
+    CmdPrefix = Clang + " -cc1 "
+
+    # For now, we assume the preprocessed files should be analyzed
+    # with the OS X SDK.
+    SDKPath = getSDKPath("macosx")
+    if SDKPath is not None:
+      CmdPrefix += "-isysroot " + SDKPath + " "
+
+    CmdPrefix += "-analyze -analyzer-output=plist -w "
     CmdPrefix += "-analyzer-checker=" + Checkers +" -fcxx-exceptions -fblocks "
 
     if (Mode == 2) :
         CmdPrefix += "-std=c++11 "
 
     PlistPath = os.path.join(Dir, SBOutputDir, "date")
     FailPath = os.path.join(PlistPath, "failures");
     os.makedirs(FailPath);