This is an archive of the discontinued LLVM Phabricator instance.

Differential D12515

Use -Wno-vla-extension globally.
ClosedPublic

Authored by brucem on Aug 31 2015, 8:14 PM.

Details

Reviewers
clayborg
Commits
rG4aed72571acd: Use -Wno-vla-extension globally.
rLLDB246605: Use -Wno-vla-extension globally.
rL246605: Use -Wno-vla-extension globally.
Summary

This was previously only established within debugserver, but
there is a use of the VLA extension in source/Host/macosx/Symbols.cpp,
so ignore this warning globally.

Diff Detail

Repository
rL LLVM

Event Timeline

brucem updated this revision to Diff 33660.Aug 31 2015, 8:14 PM
brucem retitled this revision from to Use -Wno-vla-extension globally..
brucem updated this object.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
clayborg accepted this revision.Sep 1 2015, 9:46 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Sep 1 2015, 9:46 AM
Closed by commit rL246605: Use -Wno-vla-extension globally. (authored by brucem). · Explain WhySep 1 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
cmake/
modules/
6 lines
tools/
debugserver/
source/
6 lines

Diff 33755

lldb/trunk/cmake/modules/LLDBConfig.cmake

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Lines
# Disable Clang warnings # Disable Clang warnings
check_cxx_compiler_flag("-Wno-deprecated-register" check_cxx_compiler_flag("-Wno-deprecated-register"
CXX_SUPPORTS_NO_DEPRECATED_REGISTER) CXX_SUPPORTS_NO_DEPRECATED_REGISTER)
if (CXX_SUPPORTS_NO_DEPRECATED_REGISTER) if (CXX_SUPPORTS_NO_DEPRECATED_REGISTER)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-register") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-register")
endif () endif ()
check_cxx_compiler_flag("-Wno-vla-extension"
CXX_SUPPORTS_NO_VLA_EXTENSION)
if (CXX_SUPPORTS_NO_VLA_EXTENSION)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-vla-extension")
endif ()
# Disable MSVC warnings # Disable MSVC warnings
if( MSVC ) if( MSVC )
add_definitions( add_definitions(
-wd4018 # Suppress 'warning C4018: '>=' : signed/unsigned mismatch' -wd4018 # Suppress 'warning C4018: '>=' : signed/unsigned mismatch'
-wd4068 # Suppress 'warning C4068: unknown pragma' -wd4068 # Suppress 'warning C4068: unknown pragma'
-wd4150 # Suppress 'warning C4150: deletion of pointer to incomplete type' -wd4150 # Suppress 'warning C4150: deletion of pointer to incomplete type'
-wd4251 # Suppress 'warning C4251: T must have dll-interface to be used by clients of class U.' -wd4251 # Suppress 'warning C4251: T must have dll-interface to be used by clients of class U.'
-wd4521 # Suppress 'warning C4521: 'type' : multiple copy constructors specified' -wd4521 # Suppress 'warning C4521: 'type' : multiple copy constructors specified'
▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines

lldb/trunk/tools/debugserver/source/CMakeLists.txt

Show All 10 Lines
endif() endif()
check_cxx_compiler_flag("-Wno-gnu-zero-variadic-macro-arguments" check_cxx_compiler_flag("-Wno-gnu-zero-variadic-macro-arguments"
CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS) CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS)
if (CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS) if (CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-gnu-zero-variadic-macro-arguments") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-gnu-zero-variadic-macro-arguments")
endif () endif ()
check_cxx_compiler_flag("-Wno-vla-extension"
CXX_SUPPORTS_NO_VLA_EXTENSION)
if (CXX_SUPPORTS_NO_VLA_EXTENSION)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-vla-extension")
endif ()
check_cxx_compiler_flag("-Wno-zero-length-array" check_cxx_compiler_flag("-Wno-zero-length-array"
CXX_SUPPORTS_NO_ZERO_LENGTH_ARRAY) CXX_SUPPORTS_NO_ZERO_LENGTH_ARRAY)
if (CXX_SUPPORTS_NO_ZERO_LENGTH_ARRAY) if (CXX_SUPPORTS_NO_ZERO_LENGTH_ARRAY)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-zero-length-array") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-zero-length-array")
endif () endif ()
check_cxx_compiler_flag("-Wno-extended-offsetof" check_cxx_compiler_flag("-Wno-extended-offsetof"
CXX_SUPPORTS_NO_EXTENDED_OFFSETOF) CXX_SUPPORTS_NO_EXTENDED_OFFSETOF)
Show All 38 Lines