This is an archive of the discontinued LLVM Phabricator instance.

Fix bug in method LLLexer::FP80HexToIntPair.
ClosedPublic

Authored by kschimpf on Aug 31 2015, 2:07 PM.

Reviewers

kcc
filcab

Summary

Fixes bug https://llvm.org/bugs/show_bug.cgi?id=24640. Fixes case
where code goes past end of memory buffer because it doesn't check.

kschimpf retitled this revision from to Fix bug in method LLLexer::FP80HexToIntPair..

kschimpf updated this object.

kschimpf added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Aug 31 2015, 2:27 PM

Path

Size

lib/

AsmParser/

2 lines

test/

Assembler/

6 lines

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Lines	void LLLexer::FP80HexToIntPair(const char Buffer, const char End,
uint64_t Pair[2]) {		uint64_t Pair[2]) {
Pair[1] = 0;		Pair[1] = 0;
for (int i=0; i<4 && Buffer != End; i++, Buffer++) {		for (int i=0; i<4 && Buffer != End; i++, Buffer++) {
assert(Buffer != End);		assert(Buffer != End);
Pair[1] *= 16;		Pair[1] *= 16;
Pair[1] += hexDigitValue(*Buffer);		Pair[1] += hexDigitValue(*Buffer);
}		}
Pair[0] = 0;		Pair[0] = 0;
for (int i=0; i<16; i++, Buffer++) {		for (int i = 0; i < 16 && Buffer != End; i++, Buffer++) {
Pair[0] *= 16;		Pair[0] *= 16;
Pair[0] += hexDigitValue(*Buffer);		Pair[0] += hexDigitValue(*Buffer);
}		}
if (Buffer != End)		if (Buffer != End)
Error("constant bigger than 128 bits detected!");		Error("constant bigger than 128 bits detected!");
}		}

// UnEscapeLexed - Run through the specified buffer and change \xx codes to the		// UnEscapeLexed - Run through the specified buffer and change \xx codes to the
▲ Show 20 Lines • Show All 855 Lines • Show Last 20 Lines

				; RUN: not llvm-as < %s 2>&1 \| FileCheck %s

				; Tests bug: 24640
				; CHECK: expected '=' in global variable

				@- 0xKate potb8ed