Match spec format: https://github.com/WebAssembly/spec/blob/master/ml-proto/test/fac.wasm
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
This is missing a few test updates for param and result, will do them if the overall changes looks good.
lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp | ||
---|---|---|
106 ↗ | (On Diff #33135) | Please put an assert or llvm_unreachable or something here to make sure this gets caught. |
145 ↗ | (On Diff #33135) | This is subjective, but my preference would be to omit this comment, as it adds clutter. If you want to keep it, would you mind making it lower-case? |
lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp | ||
---|---|---|
145 ↗ | (On Diff #33135) | Lowercased. I'd like to keep it since functions won't be too frequent compared to the expression trees. At least for early testing it'll make things easier to grok IMO. |