This is an archive of the discontinued LLVM Phabricator instance.

[PM/AA] Delete the LibCallAliasAnalysis and all the associated infrastructure.
ClosedPublic

Authored by chandlerc on Aug 14 2015, 2:12 AM.

Details

Summary

This AA was never used in tree. It's infrastructure also completely
overlaps that of TargetLibraryInfo which is used heavily by BasicAA to
achieve similar goals to those stated for this analysis.

As has come up in several discussions, the use case here is still really
important, but this code isn't helping move toward that use case. Any
progress on better supporting rich AA information for runtime library
environments would likely be better off starting from scratch or
starting from TargetLibraryInfo than from this base.

Diff Detail

Repository
rL LLVM

Event Timeline

chandlerc updated this revision to Diff 32141.Aug 14 2015, 2:12 AM
chandlerc retitled this revision from to [PM/AA] Delete the LibCallAliasAnalysis and all the associated infrastructure..
chandlerc updated this object.
chandlerc added a reviewer: hfinkel.
chandlerc added a subscriber: llvm-commits.
hfinkel accepted this revision.Aug 14 2015, 12:06 PM
hfinkel edited edge metadata.

LGTM.

I'll echo your statement that the use cases targeted here are really important; but this is not being used, and would need better integration into the rest of the infrastructure as it stands. Furthermore, some additional thought is required to recognize errno and other global state, perhaps especially in an LTO context.

This revision is now accepted and ready to land.Aug 14 2015, 12:06 PM
This revision was automatically updated to reflect the committed changes.
llvm/trunk/lib/Analysis/Analysis.cpp