This is an archive of the discontinued LLVM Phabricator instance.

Revised test to pass under updated dtor callback implementation
ClosedPublic

Authored by nmusgrave on Aug 11 2015, 11:18 AM.

Details

Summary

New implementation for dtor sanitizer callback poisons only class members, and emits poisoning callback before base dtor invoked.

Diff Detail

Event Timeline

nmusgrave updated this revision to Diff 31837.Aug 11 2015, 11:18 AM
nmusgrave retitled this revision from to Revised test to pass under updated dtor callback implementation.
nmusgrave updated this object.
nmusgrave added reviewers: eugenis, kcc.
eugenis added inline comments.Aug 11 2015, 11:34 AM
test/msan/dtor-base-access.cc
48

Why are you removing the destructor call?
That's exactly what this test is about.

nmusgrave updated this revision to Diff 31892.Aug 11 2015, 5:53 PM
  • Explicit dtor invocation
eugenis accepted this revision.Aug 11 2015, 5:53 PM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 11 2015, 5:53 PM
nmusgrave closed this revision.Aug 11 2015, 6:17 PM