This is an archive of the discontinued LLVM Phabricator instance.

[tests][Driver] Pass an empty sysroot for `DEFAULT_SYSROOT` builds
ClosedPublic

Authored by carlocab on Feb 7 2022, 7:31 AM.

Details

Reviewers
abidh
phosek
Summary

The baremetal-sysroot test fails when the toolchain is configured with
DEFAULT_SYSROOT. So, to emulate not having passed one at all, let's
pass an empty sysroot instead.

This simply follows D79694, D66834, and D51972. D51972 in particular was
meant to address a failing test for behaviour when --sysroot is not
passed and DEFAULT_SYSROOT is set.

Diff Detail

Event Timeline

carlocab created this revision.Feb 7 2022, 7:31 AM
carlocab requested review of this revision.Feb 7 2022, 7:31 AM
phosek accepted this revision.Feb 18 2022, 12:13 AM

LGTM

This revision is now accepted and ready to land.Feb 18 2022, 12:13 AM

Thanks Petr. I don’t have commit access, so I’d appreciate it if you could commit this for me.

Per suggestion on Discord, here’s my git author line:

Carlo Cabrera <carlo.antonio.cabrera@gmail.com>

Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 12:42 AM
phosek closed this revision.Mar 4 2022, 1:04 PM