Page MenuHomePhabricator

Use only unnamed pipes to launch lldb-server gdbserver.
ClosedPublic

Authored by chaoren on Jul 29 2015, 2:28 PM.

Details

Summary

If we used unnamed pipes instead of named pipes, we can avoid having the
file system littered with debugserver-named-pipes if lldb-server happens to
crash for whatever reason. Also, on some buggy systems, it's possible to be
able to create but not to delete a fifo. Ideally, support for unnamed pipes
should be added to debugserver as well, so we can avoid the #ifdef here.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren retitled this revision from to Use only unnamed pipes to launch lldb-server gdbserver..
chaoren updated this object.
chaoren added reviewers: clayborg, vharron, chying.
chaoren added a subscriber: lldb-commits.
clayborg requested changes to this revision.Jul 29 2015, 2:54 PM
clayborg edited edge metadata.

This stops the fallback for Apple systems where it would try and unnamed pipe if we fail to create a named pipe. Please fix. It is ok to not try named pipes on other systems, but I would like the fallback to still work for Apple just in case.

This revision now requires changes to proceed.Jul 29 2015, 2:54 PM

This stops the fallback for Apple systems where it would try and unnamed pipe if we fail to create a named pipe.

There's currently no support for passing unnamed pipes to debugserver (through --pipe), otherwise I would've removed the named pipes entirely.

clayborg accepted this revision.Jul 29 2015, 3:35 PM
clayborg edited edge metadata.

ok then, looks good as long the MacOSX test suite is happy.

This revision is now accepted and ready to land.Jul 29 2015, 3:35 PM
This revision was automatically updated to reflect the committed changes.