Print reference values on one line.

[granata.enrico]

I am assuming that your intent is:

int x = 1;
int& y = 1;

(lldb) frame variable y
(int&) y = 0x123456 (y = 1)

If so, two things:
a) a much better way would be to make FormatManager::ShouldPrintAsOneLiner() decide that a T& can be printed on one-line iff the referenced thing can
b) test cases would be great

If I am reading your intent wrong, can you please elaborate on what you're trying to achieve?

I would really appreciate if you didn't commit this.

[clayborg]

I will defer to Enrico on this one.

[chaoren]

I am assuming that your intent is:

Yep.

a) a much better way would be to make FormatManager::ShouldPrintAsOneLiner() decide that a T& can be printed on one-line iff the referenced thing can

I thought ShouldPrintAsOneLiner already does that for each of the < 50 children. The change around bool print_oneline is only refactoring for readability. The only difference is that curr_ptr_depth is not set to 1 so ShouldPrintAsOneLiner can actually get called.

[granata.enrico]

Can you please try using revision 243301 or later?

In my testing, this change makes references work the way you expect
If you're still not getting the behavior you expect, can you please include a test case that fails before your change but succeeds after? That should help ensure we don't regress, and might also help us pinpoint the correct change to make

[chaoren]

Yes, rL243301 does make references print correctly. This change won't be necessary anymore. It seems like it'd be nice to have a test case regardless. Could you please add a test case for your change?

source/DataFormatters/ValueObjectPrinter.cpp

if (is_failed_description || m_curr_depth < options.m_max_depth)
                 return false;
             
             else if (is_ref && m_curr_depth == 0 && curr_ptr_depth == 0)
             {
                 // If this is the root object (depth is zero) that we are showing
                 // and it is a reference, and no pointer depth has been supplied
                 // print out what it references. Don't do this at deeper depths
                 // otherwise we can end up with infinite recursion...
-                curr_ptr_depth = 1;
+                return true;
             }
             
             return (curr_ptr_depth > 0);
         }
         
         TypeSummaryImpl* entry = GetSummaryFormatter();
 
         return (!entry || entry->DoesPrintChildren(m_valobj) || m_summary.empty());

 
 void
 ValueObjectPrinter::PrintChildrenIfNeeded (bool value_printed,
                                            bool summary_printed)
 {
     // this flag controls whether we tried to display a description for this object and failed
     // if that happens, we want to display the children, if any
     bool is_failed_description = !PrintObjectDescriptionIfNeeded(value_printed, summary_printed);
-    
     uint32_t curr_ptr_depth = m_ptr_depth;
     bool print_children = ShouldPrintChildren (is_failed_description,curr_ptr_depth);
-    bool print_oneline = (curr_ptr_depth > 0 ||
-                          options.m_show_types ||
-                          !options.m_allow_oneliner_mode ||
-                          options.m_flat_output ||
-                          options.m_show_location) ? false : DataVisualization::ShouldPrintAsOneLiner(*m_valobj);
-    
+    bool print_oneline = curr_ptr_depth == 0 &&
+                         !options.m_show_types &&
+                         options.m_allow_oneliner_mode &&
+                         !options.m_flat_output &&
+                         !options.m_show_location &&
+                         DataVisualization::ShouldPrintAsOneLiner(*m_valobj);
     if (print_children)
     {
         if (print_oneline)
         {
             m_stream->PutChar(' ');
             PrintChildrenOneLiner (false);
             m_stream->EOL();
         }