[MIPS] Create Unix Signals based on target architecture

[jaydeep]

Summary

The patch creates Unix Signals based on target architecture. For MIPS it creates MipsLinuxSignals.

[clayborg]

Fix logic as suggested in the second inline code snippet.

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

827

UnixSignals::Create() is a static function. If this is really what you are intending to do this should be:

if (error.Success())
    SetUnixSignals(UnixSignals::Create(GetTarget().GetArchitecture());

But this ins't the intention here. We need to ask if the platform is connected and if so, use the unix signals returned by the platform. It is isn't use UnixSignals::Create(<arch>). So this code should be:

if (error.Success())
{
    PlatformSP platform_sp = GetTarget().GetPlatform():
    if (platform_sp && platform_sp->IsConnected())
        SetUnixSignals(platform_sp->GetUnixSignals());
    else
        SetUnixSignals(UnixSignals::Create(GetTarget().GetArchitecture());
}
`

[jaydeep]

Thanks Greg
Addressed review comments.

[jaydeep]

Could you please find some time to review this?
Thanks

[clayborg]

Looks good.

[jaydeep]

Closed by commit rL243618

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

if (error.Success()
         else
             GetTarget().SetArchitecture(m_gdb_comm.GetHostArchitecture());
     }
 
     if (log)
         log->Printf ("ProcessGDBRemote::%s pid %" PRIu64 ": normalized target architecture triple: %s", __FUNCTION__, GetID (), GetTarget ().GetArchitecture ().GetTriple ().getTriple ().c_str ());
 
     if (error.Success())
-        SetUnixSignals(std::make_shared<GDBRemoteSignals>(GetTarget().GetPlatform()->GetUnixSignals()));
+    {
+        PlatformSP platform_sp = GetTarget().GetPlatform();
+        if (platform_sp && platform_sp->IsConnected())
+            SetUnixSignals(platform_sp->GetUnixSignals());
+        else
+            SetUnixSignals(UnixSignals::Create(GetTarget().GetArchitecture()));
+    }
 
     return error;
 }
 
 Error
 ProcessGDBRemote::WillLaunchOrAttach ()
 {
     Error error;