Initialize variable to prevent garbage values (RenderScriptRuntime)

[• neilparikh]

Summary

The kernels_found variable is not initialized, so if it is not assigned true on line 823, then it will be a garbage value in the branch condition on line 828. This patch initializes the variable to false. I'm assuming that if it's not set, then it was not found. I'm not 100% sure about this, so a confirmation of this would be good.

This is my first patch to an LLVM project, so please let me know if there's anything I need to fix. I haven't built or run the test suite yet, but if it's required to commit the patch, I can look into figuring that out.

[domipheus]

LGTM, sorry for the delay.

[• neilparikh]

No problem, thanks. What's the process to commit this (I don't have commit access)?

[domipheus]

http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

All explained there :)

[• neilparikh]

That site says that commit access is granted after a few patches. This is my first patch, so it seems like I need to get someone else commit it for me (based on how I interpreted that page). If that's the case, could you commit this?

lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp

 RenderScriptRuntime::AttemptBreakpointAtKernelName(Stream &strm, const char* name, Error& error)
 {
     if (!name) 
     {
         error.SetErrorString("invalid kernel name");
         return;
     }
 
-    bool kernels_found;
+    bool kernels_found = false;
     ConstString kernel_name(name);
     for (const auto &module : m_rsmodules)
     {
         for (const auto &kernel : module->m_kernels)
         {
             if (kernel.m_name == kernel_name)
             {
                 //Attempt to set a breakpoint on this symbol, within the module library