This is an archive of the discontinued LLVM Phabricator instance.

Handle altsep ('/' on Windows) in compiler path for log files.
ClosedPublic

Authored by chaoren on Jul 17 2015, 2:20 PM.

Reviewers

Commits

chaoren retitled this revision from to Handle altsep ('/' on Windows) in compiler path for log files..

chaoren updated this object.

chaoren added a reviewer: chying.

chaoren added a subscriber: lldb-commits.

should be
compiler = compiler.replace(os.path.altsep, os.path.sep)?
.replace doesn't change the original copy

Oops.

looks good

This revision is now accepted and ready to land.Jul 17 2015, 2:37 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

trunk/

test/

1 line

Show First 20 Lines • Show All 1,645 Lines • ▼ Show 20 Lines	def getLogBasenameForCurrentTest(self, prefix=None):
os.environ["LLDB_SESSION_DIRNAME"])		os.environ["LLDB_SESSION_DIRNAME"])
if not os.path.isdir(dname):		if not os.path.isdir(dname):
os.mkdir(dname)		os.mkdir(dname)

compiler = self.getCompiler()		compiler = self.getCompiler()

if compiler[1] == ':':		if compiler[1] == ':':
compiler = compiler[2:]		compiler = compiler[2:]
		compiler = compiler.replace(os.path.altsep, os.path.sep)

fname = "{}-{}-{}".format(self.id(), self.getArchitecture(), "_".join(compiler.split(os.path.sep)))		fname = "{}-{}-{}".format(self.id(), self.getArchitecture(), "_".join(compiler.split(os.path.sep)))
if len(fname) > 200:		if len(fname) > 200:
fname = "{}-{}-{}".format(self.id(), self.getArchitecture(), compiler.split(os.path.sep)[-1])		fname = "{}-{}-{}".format(self.id(), self.getArchitecture(), compiler.split(os.path.sep)[-1])

if prefix is not None:		if prefix is not None:
fname = "{}-{}".format(prefix, fname)		fname = "{}-{}".format(prefix, fname)

▲ Show 20 Lines • Show All 974 Lines • Show Last 20 Lines