Page MenuHomePhabricator

Implement FileSystem::GetPermissions for Windows.
ClosedPublic

Authored by amccarth on Jul 17 2015, 10:44 AM.

Details

Reviewers
chaoren
Summary

I'm working on loading Windows mini dumps (like Linux core files). I'm doing this change as a separate PATCH in order to break the work into digestible chunks.

The core-loading code calls FileSpec::Readable (twice!) before attempting to open the file, so we need GetPermissions to indicate whether the user can read the file.

Diff Detail

Event Timeline

amccarth updated this revision to Diff 30014.Jul 17 2015, 10:44 AM
amccarth retitled this revision from to Implement FileSystem::GetPermissions for Windows..
amccarth updated this object.
amccarth added a reviewer: chaoren.
amccarth added a subscriber: lldb-commits.
chaoren accepted this revision.Jul 17 2015, 11:41 AM
chaoren edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jul 17 2015, 11:41 AM