Page MenuHomePhabricator

Fix -data-info-line when source includes column number.
ClosedPublic

Authored by dawn on Jul 14 2015, 6:07 PM.

Details

Summary

This fixes an off-by-one bug in CMICmdCmdDataInfoLine::Acknowledge. Given:

LineEntry: \[0x0000000100000f37-0x0000000100000f45\): /path/to/file:123:1

-data-info-line would report the line as 12, omitting the last digit.

Diff Detail

Repository
rL LLVM

Event Timeline

dawn updated this revision to Diff 29740.Jul 14 2015, 6:07 PM
dawn retitled this revision from to Fix -data-info-line when source includes column number..
dawn updated this object.
dawn added reviewers: abidh, brucem, ki.stfu.
dawn set the repository for this revision to rL LLVM.
dawn added a subscriber: lldb-commits.
ki.stfu accepted this revision.Jul 15 2015, 2:30 AM
ki.stfu edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2015, 2:30 AM
abidh accepted this revision.Jul 15 2015, 2:30 AM
abidh edited edge metadata.

Looks good.

This revision was automatically updated to reflect the committed changes.