Use target.exec-search-paths setting when resolving executable path for remote target.

[ovyalov]

Summary

Use target.exec-search-paths setting when resolving executable path for remote target.
Additionally check for valid module's UUID on host side - if module has valid UUID we can try lookup it locally, even if full path doesn't exist on a host..

[clayborg]

Looks good.

[tberghammer]

source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

672

(nit): I would prefer to remove the inverse logic in the ?: operator

[ovyalov]

Review fixes.

source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

672

Done.

[ovyalov]

Files:

/lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
/lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp
/lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp

Users:

ovyalov (Author)

http://reviews.llvm.org/rL242183

source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

DynamicLoaderPOSIXDYLD::ResolveExecutableModule (lldb::ModuleSP &module_sp)
     if (log)
         log->Printf ("DynamicLoaderPOSIXDYLD::%s - got executable by pid %" PRIu64 ": %s",
                      __FUNCTION__, m_process->GetID (), process_info.GetExecutableFile ().GetPath ().c_str ());
 
     ModuleSpec module_spec (process_info.GetExecutableFile (), process_info.GetArchitecture ());
     if (module_sp && module_sp->MatchesModuleSpec (module_spec))
         return;
 
-    auto error = platform_sp->ResolveExecutable (module_spec, module_sp, nullptr);
+    const auto executable_search_paths (Target::GetDefaultExecutableSearchPaths());
+    auto error = platform_sp->ResolveExecutable (
+        module_spec, module_sp, executable_search_paths.IsEmpty() ? nullptr : &executable_search_paths);
     if (error.Fail ())
     {
         StreamString stream;
         module_spec.Dump (stream);
 
         if (log)
             log->Printf ("DynamicLoaderPOSIXDYLD::%s - failed to resolve executable with module spec \"%s\": %s",
                          __FUNCTION__, stream.GetString ().c_str (), error.AsCString ());
         return;
     }
 
     target.SetExecutableModule (module_sp, false);
 }

source/Plugins/Platform/Linux/PlatformLinux.cpp

if (IsHost())
         {
             error.SetErrorStringWithFormat("unable to find executable for '%s'", resolved_module_spec.GetFileSpec().GetPath().c_str());
         }
     }
     else
     {
         if (m_remote_platform_sp)
         {
-            error = GetCachedExecutable (resolved_module_spec, exe_module_sp, nullptr, *m_remote_platform_sp);
+            error = GetCachedExecutable (resolved_module_spec, exe_module_sp, module_search_paths_ptr, *m_remote_platform_sp);
         }
         else
         {
             // We may connect to a process and use the provided executable (Don't use local $PATH).
 
             if (resolved_module_spec.GetFileSpec().Exists())
                 error.Clear();
             else

source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp

PlatformRemoteGDBServer::ResolveExecutable (const ModuleSpec &module_spec,
     Error error;
     // Nothing special to do here, just use the actual file and architecture
 
     ModuleSpec resolved_module_spec(module_spec);
 
     // Resolve any executable within an apk on Android?
     //Host::ResolveExecutableInBundle (resolved_module_spec.GetFileSpec());
 
-    if (resolved_module_spec.GetFileSpec().Exists())
+    if (resolved_module_spec.GetFileSpec().Exists() ||
+        module_spec.GetUUID().IsValid())
     {
         if (resolved_module_spec.GetArchitecture().IsValid() || resolved_module_spec.GetUUID().IsValid())
         {
             error = ModuleList::GetSharedModule (resolved_module_spec,
                                                  exe_module_sp,
-                                                 NULL,
+                                                 module_search_paths_ptr,
                                                  NULL,
                                                  NULL);
 
             if (exe_module_sp && exe_module_sp->GetObjectFile())
                 return error;
             exe_module_sp.reset();
         }
         // No valid architecture was specified or the exact arch wasn't
         // found so ask the platform for the architectures that we should be
         // using (in the correct order) and see if we can find a match that way
         StreamString arch_names;
         for (uint32_t idx = 0; GetSupportedArchitectureAtIndex (idx, resolved_module_spec.GetArchitecture()); ++idx)
         {
             error = ModuleList::GetSharedModule (resolved_module_spec,
                                                  exe_module_sp,
-                                                 NULL,
+                                                 module_search_paths_ptr,
                                                  NULL,
                                                  NULL);
             // Did we find an executable using one of the
             if (error.Success())
             {
                 if (exe_module_sp && exe_module_sp->GetObjectFile())
                     break;
                 else