Page MenuHomePhabricator

Use target.exec-search-paths setting when resolving executable path for remote target.
ClosedPublic

Authored by ovyalov on Jul 13 2015, 4:09 PM.

Details

Summary

Use target.exec-search-paths setting when resolving executable path for remote target.
Additionally check for valid module's UUID on host side - if module has valid UUID we can try lookup it locally, even if full path doesn't exist on a host..

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 29620.Jul 13 2015, 4:09 PM
ovyalov retitled this revision from to Use target.exec-search-paths setting when resolving executable path for remote target..
ovyalov updated this object.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
clayborg accepted this revision.Jul 13 2015, 4:59 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jul 13 2015, 4:59 PM
tberghammer accepted this revision.Jul 14 2015, 2:12 AM
tberghammer edited edge metadata.
tberghammer added inline comments.
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
672

(nit): I would prefer to remove the inverse logic in the ?: operator

ovyalov updated this revision to Diff 29694.Jul 14 2015, 11:48 AM
ovyalov edited edge metadata.

Review fixes.

source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
672

Done.

ovyalov closed this revision.Jul 14 2015, 12:00 PM

Files:

/lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
/lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp
/lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp

Users:

ovyalov (Author)

http://reviews.llvm.org/rL242183